[Misc] Rename DamagePhase to DamageAnimPhase
#4880
Open
+86
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+4
| import type BattleScene from "#app/battle-scene"; | ||
| import { type BattlerIndex } from "#app/battle"; | ||
| import { BattleSpec } from "#enums/battle-spec"; | ||
| import { type DamageResult, HitResult } from "#app/field/pokemon"; |
There was a problem hiding this comment.
Type-only imports are not added to the transpiled js. All imports should be type-only when they are only used as type hints (btw VSCode users, enable "prefer type only imports" from your settings which for some insane reason isn't enabled by default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
The phase name is misleading as it doesn't actually calculate damage or anything, just play the animations for damage numbers appearing.
What are the changes from a developer perspective?
Renamed
DamagePhasetoDamageAnimPhaseand the file fromdamage-phase.tstodamage-anim-phase.ts.Checklist
betaas my base branch[ ] Have I considered writing automated tests for the issue?[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?[ ] Have I tested the changes (manually)?npm run test)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?